Fixes trash carts not working with fultons #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Feb 5, 2024
|
Tested locally, seems to work but the trash cart layers under the attachment |
|
Yeah I noticed that too. As far as I can tell it's probably been an issue for a few years. It's a bit late for me now, but I can try looking into a fix tomorrow? One of them probably just needs to be moved to a different plane. |
|
Done! I've put it in a second PR rather than this one just in case. (#5673) |
BeagleGaming1
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #5621, which was caused by a runtime in
/obj/structure/dropship_equipment/fulton_system/proc/automate_interact().The cart's entry in
possible_fultonshas a key of"�\u{16}trash cart", but thefulton_choicepassed from the UI is just"trash cart". Because they don't match,fultis unable to be set, and an error is thrown on L1154.cmss13/code/modules/cm_marines/dropship_equipment.dm
Lines 1141 to 1154 in 2657502
Explain why it's good for the game
Bugfix!
Testing Photographs and Procedure
Screenshots & Videos
Before:
Runtime error. (I can't be bothered to go through the set up again just to record this)
After:
dreamseeker_CtCdInkfxp.mp4
Changelog
🆑
fix: Fixed trash carts not being pick-uppable by the dropship's fulton recovery system.
/:cl: